From 97c8d82b338be04c513df4d15f1ef72a6fbbed4c Mon Sep 17 00:00:00 2001
From: Ottermandias <nickroederspam+git1@gmail.com>
Date: Sun, 7 Sep 2025 10:45:28 +0200
Subject: [PATCH] Prevent default-named collection from being renamed and
 always put it at the top of the selector.

---
 Penumbra/UI/CollectionTab/CollectionPanel.cs  | 44 ++++++++++---------
 .../UI/CollectionTab/CollectionSelector.cs    |  3 +-
 2 files changed, 26 insertions(+), 21 deletions(-)

diff --git a/Penumbra/UI/CollectionTab/CollectionPanel.cs b/Penumbra/UI/CollectionTab/CollectionPanel.cs
index 26fa2b14..e41ceade 100644
--- a/Penumbra/UI/CollectionTab/CollectionPanel.cs
+++ b/Penumbra/UI/CollectionTab/CollectionPanel.cs
@@ -11,6 +11,7 @@ using OtterGui;
 using OtterGui.Classes;
 using OtterGui.Extensions;
 using OtterGui.Raii;
+using OtterGui.Text;
 using Penumbra.Collections;
 using Penumbra.Collections.Manager;
 using Penumbra.GameData.Actors;
@@ -222,26 +223,31 @@ public sealed class CollectionPanel(
         ImGui.EndGroup();
         ImGui.SameLine();
         ImGui.BeginGroup();
-        using var style      = ImRaii.PushStyle(ImGuiStyleVar.ButtonTextAlign, new Vector2(0, 0.5f));
-        var       name       = _newName ?? collection.Identity.Name;
-        var       identifier = collection.Identity.Identifier;
-        var       width      = ImGui.GetContentRegionAvail().X;
-        var       fileName   = saveService.FileNames.CollectionFile(collection);
-        ImGui.SetNextItemWidth(width);
-        if (ImGui.InputText("##name", ref name, 128))
-            _newName = name;
-        if (ImGui.IsItemDeactivatedAfterEdit() && _newName != null && _newName != collection.Identity.Name)
+        var width = ImGui.GetContentRegionAvail().X;
+        using (ImRaii.Disabled(_collections.DefaultNamed == collection))
         {
-            collection.Identity.Name = _newName;
-            saveService.QueueSave(new ModCollectionSave(mods, collection));
-            selector.RestoreCollections();
-            _newName = null;
-        }
-        else if (ImGui.IsItemDeactivated())
-        {
-            _newName = null;
+            using var style = ImRaii.PushStyle(ImGuiStyleVar.ButtonTextAlign, new Vector2(0, 0.5f));
+            var       name  = _newName ?? collection.Identity.Name;
+            ImGui.SetNextItemWidth(width);
+            if (ImGui.InputText("##name", ref name, 128))
+                _newName = name;
+            if (ImGui.IsItemDeactivatedAfterEdit() && _newName != null && _newName != collection.Identity.Name)
+            {
+                collection.Identity.Name = _newName;
+                saveService.QueueSave(new ModCollectionSave(mods, collection));
+                selector.RestoreCollections();
+                _newName = null;
+            }
+            else if (ImGui.IsItemDeactivated())
+            {
+                _newName = null;
+            }
         }
+        if (_collections.DefaultNamed == collection)
+            ImUtf8.HoverTooltip(ImGuiHoveredFlags.AllowWhenDisabled, "The Default collection can not be renamed."u8);
 
+        var identifier = collection.Identity.Identifier;
+        var fileName   = saveService.FileNames.CollectionFile(collection);
         using (ImRaii.PushFont(UiBuilder.MonoFont))
         {
             if (ImGui.Button(collection.Identity.Identifier, new Vector2(width, 0)))
@@ -375,9 +381,7 @@ public sealed class CollectionPanel(
             ImGuiUtil.TextWrapped(type.ToDescription());
             switch (type)
             {
-                case CollectionType.Default:
-                    ImGui.TextUnformatted("Overruled by any other Assignment.");
-                    break;
+                case CollectionType.Default: ImGui.TextUnformatted("Overruled by any other Assignment."); break;
                 case CollectionType.Yourself:
                     ImGuiUtil.DrawColoredText(("Overruled by ", 0), ("Individual ", ColorId.NewMod.Value()), ("Assignments.", 0));
                     break;
diff --git a/Penumbra/UI/CollectionTab/CollectionSelector.cs b/Penumbra/UI/CollectionTab/CollectionSelector.cs
index e54f994e..79254090 100644
--- a/Penumbra/UI/CollectionTab/CollectionSelector.cs
+++ b/Penumbra/UI/CollectionTab/CollectionSelector.cs
@@ -116,7 +116,8 @@ public sealed class CollectionSelector : ItemSelector<ModCollection>, IDisposabl
     public void RestoreCollections()
     {
         Items.Clear();
-        foreach (var c in _storage.OrderBy(c => c.Identity.Name))
+        Items.Add(_storage.DefaultNamed);
+        foreach (var c in _storage.OrderBy(c => c.Identity.Name).Where(c => c != _storage.DefaultNamed))
             Items.Add(c);
         SetFilterDirty();
         SetCurrent(_active.Current);