ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-13 12:14:16 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix: add a full item link to SeStringBuilder

Browse source 
This changes the behaviour of `AddItemLink` functions.
Previously it just added an `ItemPayload`.
Now, it adds a full item link, as one would expect.
This commit is contained in:
Haselnussbomber 2023-08-01 18:57:00 +02:00
parent 3f78df23e3
commit 08100ef572
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Dalamud/Game/Text/SeStringHandling/SeString.cs
View file

@ -208,6 +208,7 @@ public class SeString
var textColor = (ushort)(549 + ((rarity - 1) * 2)); var textColor = (ushort)(549 + ((rarity - 1) * 2));
var textGlowColor = (ushort)(textColor + 1); var textGlowColor = (ushort)(textColor + 1);
// Note: `SeStringBuilder.AddItemLink` uses this function, so don't call it here!
return new SeStringBuilder() return new SeStringBuilder()
.Add(new ItemPayload(itemId, kind)) .Add(new ItemPayload(itemId, kind))
.Append(TextArrowPayloads) .Append(TextArrowPayloads)

4
Dalamud/Game/Text/SeStringHandling/SeStringBuilder.cs
View file

@ -114,7 +114,7 @@ public class SeStringBuilder
/// <param name="itemNameOverride">Override for the item's name.</param> /// <param name="itemNameOverride">Override for the item's name.</param>
/// <returns>The current builder.</returns> /// <returns>The current builder.</returns>
public SeStringBuilder AddItemLink(uint itemId, bool isHq, string? itemNameOverride = null) => public SeStringBuilder AddItemLink(uint itemId, bool isHq, string? itemNameOverride = null) =>
this.Add(new ItemPayload(itemId, isHq, itemNameOverride)); this.Append(SeString.CreateItemLink(itemId, isHq, itemNameOverride));
/// <summary> /// <summary>
/// Add an item link to the builder. /// Add an item link to the builder.
@ -124,7 +124,7 @@ public class SeStringBuilder
/// <param name="itemNameOverride">Override for the item's name.</param> /// <param name="itemNameOverride">Override for the item's name.</param>
/// <returns>The current builder.</returns> /// <returns>The current builder.</returns>
public SeStringBuilder AddItemLink(uint itemId, ItemPayload.ItemKind kind, string? itemNameOverride = null) => public SeStringBuilder AddItemLink(uint itemId, ItemPayload.ItemKind kind, string? itemNameOverride = null) =>
this.Add(new ItemPayload(itemId, kind, itemNameOverride)); this.Append(SeString.CreateItemLink(itemId, kind, itemNameOverride));
/// <summary> /// <summary>
/// Add an item link to the builder. /// Add an item link to the builder.