ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-15 21:24:16 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix CA1862: Use the 'StringComparison' method overloads to perform case-insensitive string comparisons

Browse source
This commit is contained in:
Haselnussbomber 2025-10-24 02:52:58 +02:00
parent e34c480290
commit 58aeb11268
No known key found for this signature in database
GPG key ID: BB905BB49E7295D1
5 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Dalamud/Hooking/Hook.cs
View file

@ -159,7 +159,7 @@ public abstract class Hook<T> : IDalamudHook where T : Delegate
(int)Math.Min(pDataDirectory->Size + pDataDirectory->VirtualAddress - importDescriptor.Name, moduleNameLowerWithNullTerminator.Length));
// Is this entry about the DLL that we're looking for? (Case insensitive)
if (currentDllNameWithNullTerminator.ToLowerInvariant() != moduleNameLowerWithNullTerminator)
if (!currentDllNameWithNullTerminator.Equals(moduleNameLowerWithNullTerminator, StringComparison.InvariantCultureIgnoreCase))
continue;
if (isPe64)

4
Dalamud/Interface/FontAwesome/FontAwesomeHelpers.cs
View file

@ -68,7 +68,7 @@ public static class FontAwesomeHelpers
{
var name = Enum.GetName(icon)?.ToLowerInvariant();
var searchTerms = icon.GetSearchTerms();
if (name!.Contains(search.ToLowerInvariant()) || searchTerms.Contains(search.ToLowerInvariant()))
if (name!.Contains(search, StringComparison.InvariantCultureIgnoreCase) || searchTerms.Contains(search.ToLowerInvariant()))
{
result.Add(icon);
}
@ -98,7 +98,7 @@ public static class FontAwesomeHelpers
var name = Enum.GetName(icon)?.ToLowerInvariant();
var searchTerms = icon.GetSearchTerms();
var categories = icon.GetCategories();
if ((name!.Contains(search.ToLowerInvariant()) || searchTerms.Contains(search.ToLowerInvariant())) && categories.Contains(category))
if ((name!.Contains(search, StringComparison.InvariantCultureIgnoreCase) || searchTerms.Contains(search.ToLowerInvariant())) && categories.Contains(category))
{
result.Add(icon);
}

2
Dalamud/Interface/ImGuiFileDialog/FileDialog.Filters.cs
View file

@ -89,7 +89,7 @@ public partial class FileDialog
foreach (var file in this.files)
{
var show = true;
if (!string.IsNullOrEmpty(this.searchBuffer) && !file.FileName.ToLowerInvariant().Contains(this.searchBuffer.ToLowerInvariant()))
if (!string.IsNullOrEmpty(this.searchBuffer) && !file.FileName.Contains(this.searchBuffer, StringComparison.InvariantCultureIgnoreCase))
{
show = false;
}

2
Dalamud/Interface/Internal/DalamudCommands.cs
View file

@ -326,7 +326,7 @@ internal class DalamudCommands : IServiceType
var configuration = Service<DalamudConfiguration>.Get();
var localization = Service<Localization>.Get();
if (Localization.ApplicableLangCodes.Contains(arguments.ToLowerInvariant()) || arguments.ToLowerInvariant() == "en")
if (Localization.ApplicableLangCodes.Contains(arguments.ToLowerInvariant()) || arguments.Equals("en", StringComparison.InvariantCultureIgnoreCase))
{
localization.SetupWithLangCode(arguments.ToLowerInvariant());
configuration.LanguageOverride = arguments.ToLowerInvariant();

2
Dalamud/Interface/Internal/UiDebug.cs
View file

@ -557,7 +557,7 @@ internal unsafe class UiDebug
var name = unitBase->NameString;
if (searching)
{
if (name == null || !name.ToLowerInvariant().Contains(searchStr.ToLowerInvariant())) continue;
if (name == null || !name.Contains(searchStr, StringComparison.InvariantCultureIgnoreCase)) continue;
}
noResults = false;