chore: fix some warnings, cleanup

Dalamud/Configuration/Internal/DalamudConfiguration.cs

@@ -3,8 +3,8 @@ using System.Collections.Generic;
 using System.Globalization;
 using System.IO;
 using System.Linq;
+
 using Dalamud.Game.Text;
-using Dalamud.Interface.GameFonts;
 using Dalamud.Interface.Style;
 using Newtonsoft.Json;
 using Serilog;

Dalamud/EntryPoint.cs

@@ -1,15 +1,12 @@
 using System;
 using System.Diagnostics;
 using System.IO;
-using System.Linq;
 using System.Net;
 using System.Runtime.InteropServices;
-using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
 
 using Dalamud.Configuration.Internal;
-using Dalamud.Game;
 using Dalamud.Logging.Internal;
 using Dalamud.Support;
 using Dalamud.Utility;

Dalamud/Game/ChatHandlers.cs

@@ -18,7 +18,6 @@ using Dalamud.Interface.Internal.Windows;
 using Dalamud.IoC;
 using Dalamud.IoC.Internal;
 using Dalamud.Plugin.Internal;
-using Dalamud.Plugin.Internal.Types;
 using Dalamud.Utility;
 using Serilog;
 

Dalamud/Game/ClientState/JobGauge/Types/DRGGauge.cs

@@ -1,7 +1,5 @@
 using System;
 
-using Dalamud.Game.ClientState.JobGauge.Enums;
-
 namespace Dalamud.Game.ClientState.JobGauge.Types
 {
     /// <summary>

Dalamud/Game/ClientState/Party/PartyMember.cs

@@ -7,7 +7,6 @@ using Dalamud.Game.ClientState.Resolvers;
 using Dalamud.Game.ClientState.Statuses;
 using Dalamud.Game.Text.SeStringHandling;
 using Dalamud.Memory;
-using JetBrains.Annotations;
 
 namespace Dalamud.Game.ClientState.Party
 {

Dalamud/Game/FrameworkAddressResolver.cs

@@ -1,8 +1,6 @@
 using System;
 using System.Runtime.InteropServices;
 
-using Dalamud.Game.Internal;
-
 namespace Dalamud.Game
 {
     /// <summary>

Dalamud/Game/Gui/ChatGuiAddressResolver.cs

@@ -1,7 +1,5 @@
 using System;
 
-using Dalamud.Game.Internal;
-
 namespace Dalamud.Game.Gui
 {
     /// <summary>

Dalamud/Game/Gui/ContextMenus/GameObjectContext.cs

@@ -1,6 +1,4 @@
-using Dalamud.Game.Text.SeStringHandling;
-
-namespace Dalamud.Game.Gui.ContextMenus
+namespace Dalamud.Game.Gui.ContextMenus
 {
     /// <summary>
     /// Provides game object context to a context menu.

Dalamud/Game/Gui/GameGuiAddressResolver.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Runtime.InteropServices;
 
 namespace Dalamud.Game.Gui
 {

Dalamud/Game/Gui/PartyFinder/Types/JobFlagsExtensions.cs

@@ -1,5 +1,3 @@
-using System;
-
 using Dalamud.Data;
 using Lumina.Excel.GeneratedSheets;
 

Dalamud/Game/Libc/LibcFunctionAddressResolver.cs

@@ -1,7 +1,5 @@
 using System;
 
-using Dalamud.Game.Internal;
-
 namespace Dalamud.Game.Libc
 {
     /// <summary>

Dalamud/Game/Network/GameNetworkAddressResolver.cs

@@ -1,7 +1,5 @@
 using System;
 
-using Dalamud.Game.Internal;
-
 namespace Dalamud.Game.Network
 {
     /// <summary>

Dalamud/Game/Network/Internal/WinSockHandlers.cs

@@ -3,7 +3,6 @@ using System.Net.Sockets;
 using System.Runtime.InteropServices;
 
 using Dalamud.Hooking;
-using Dalamud.Hooking.Internal;
 
 namespace Dalamud.Game.Network.Internal
 {

Dalamud/Game/Text/SeStringHandling/Payloads/EmphasisItalicPayload.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Collections.Generic;
 using System.IO;
 

Dalamud/Game/Text/SeStringHandling/Payloads/ItemPayload.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;

Dalamud/Game/Text/SeStringHandling/SeStringManager.cs

@@ -1,10 +1,6 @@
 using System;
 using System.Collections.Generic;
-using System.IO;
-using System.Linq;
 
-using Dalamud.Data;
-using Dalamud.Game.Text.SeStringHandling.Payloads;
 using Dalamud.IoC;
 using Dalamud.IoC.Internal;
 using Lumina.Excel.GeneratedSheets;

Dalamud/Hooking/Hook.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Collections.Generic;
 using System.Reflection;
 
 using Dalamud.Configuration.Internal;

Dalamud/Hooking/Internal/HookManager.cs

@@ -4,11 +4,9 @@ using System.Collections.Generic;
 using System.Linq;
 using System.Runtime.InteropServices;
 
-using Dalamud.Configuration.Internal;
 using Dalamud.Logging.Internal;
 using Dalamud.Memory;
 using Iced.Intel;
-using Microsoft.Win32;
 
 namespace Dalamud.Hooking.Internal
 {

Dalamud/Interface/GameFonts/FdtReader.cs

@@ -1,9 +1,6 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using System.Runtime.InteropServices;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace Dalamud.Interface.GameFonts
 {

Dalamud/Interface/GameFonts/GameFontFamily.cs

@@ -1,9 +1,3 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
 namespace Dalamud.Interface.GameFonts
 {
     /// <summary>

Dalamud/Interface/GameFonts/GameFontLayoutPlan.cs

@@ -1,9 +1,6 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using System.Numerics;
-using System.Text;
-using System.Threading.Tasks;
 
 using ImGuiNET;
 

Dalamud/Interface/GameFonts/GameFontManager.cs

@@ -5,7 +5,6 @@ using System.Numerics;
 using System.Runtime.InteropServices;
 using System.Text;
 
-using Dalamud.Configuration.Internal;
 using Dalamud.Data;
 using Dalamud.Interface.Internal;
 using ImGuiNET;

Dalamud/Interface/GameFonts/GameFontStyle.cs

@@ -1,8 +1,4 @@
 using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace Dalamud.Interface.GameFonts
 {

Dalamud/Interface/ImGuiFileDialog/FileDialog.Files.cs

@@ -3,8 +3,6 @@ using System.Collections.Generic;
 using System.IO;
 using System.Linq;
 
-using Dalamud.Interface;
-
 namespace Dalamud.Interface.ImGuiFileDialog
 {
     /// <summary>

Dalamud/Interface/ImGuiFileDialog/FileDialog.Structs.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Collections.Generic;
 using System.Numerics;
 

Dalamud/Interface/ImGuiFileDialog/ImGuiFileDialogFlags.cs

@@ -1,8 +1,4 @@
 using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace Dalamud.Interface.ImGuiFileDialog
 {

Dalamud/Interface/Internal/InterfaceManager.cs

@@ -15,11 +15,9 @@ using Dalamud.Game.ClientState.Keys;
 using Dalamud.Game.Gui.Internal;
 using Dalamud.Game.Internal.DXGI;
 using Dalamud.Hooking;
-using Dalamud.Hooking.Internal;
 using Dalamud.Interface.GameFonts;
 using Dalamud.Interface.Internal.ManagedAsserts;
 using Dalamud.Interface.Internal.Notifications;
-using Dalamud.Interface.Internal.Windows.StyleEditor;
 using Dalamud.Interface.Style;
 using Dalamud.Interface.Windowing;
 using Dalamud.Utility;

Dalamud/Interface/Internal/UiDebug.cs

@@ -1,9 +1,5 @@
 using System;
-using System.Collections.Generic;
-using System.Diagnostics;
 using System.Numerics;
-using System.Reflection;
-using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
 using Dalamud.Game;
@@ -19,7 +15,7 @@ namespace Dalamud.Interface.Internal
     /// <summary>
     /// This class displays a debug window to inspect native addons.
     /// </summary>
-    internal unsafe class UIDebug
+    internal unsafe class UiDebug
     {
         private const int UnitListCount = 18;
 
@@ -52,9 +48,9 @@ namespace Dalamud.Interface.Internal
         private AtkUnitBase* selectedUnitBase = null;
 
         /// <summary>
-        /// Initializes a new instance of the <see cref="UIDebug"/> class.
+        /// Initializes a new instance of the <see cref="UiDebug"/> class.
         /// </summary>
-        public UIDebug()
+        public UiDebug()
         {
             var sigScanner = Service<SigScanner>.Get();
             var getSingletonAddr = sigScanner.ScanText("E8 ?? ?? ?? ?? 41 B8 01 00 00 00 48 8D 15 ?? ?? ?? ?? 48 8B 48 20 E8 ?? ?? ?? ?? 48 8B CF");

Dalamud/Interface/Internal/Windows/ChangelogWindow.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Diagnostics;
 using System.IO;
 using System.Numerics;
 

Dalamud/Interface/Internal/Windows/CreditsWindow.cs

@@ -4,7 +4,6 @@ using System.IO;
 using System.Linq;
 using System.Numerics;
 
-using Dalamud.Game;
 using Dalamud.Game.Gui;
 using Dalamud.Interface.Windowing;
 using Dalamud.Plugin.Internal;

Dalamud/Interface/Internal/Windows/DataWindow.cs

@@ -72,7 +72,7 @@ namespace Dalamud.Interface.Internal.Windows
         private bool resolveGameData = false;
         private bool resolveObjects = false;
 
-        private UIDebug addonInspector = null;
+        private UiDebug addonInspector = null;
 
         private Hook<MessageBoxWDelegate>? messageBoxMinHook;
         private bool hookUseMinHook = false;
@@ -877,7 +877,7 @@ namespace Dalamud.Interface.Internal.Windows
 
         private void DrawAddonInspector()
         {
-            this.addonInspector ??= new UIDebug();
+            this.addonInspector ??= new UiDebug();
             this.addonInspector.Draw();
         }
 

Dalamud/Interface/Internal/Windows/PluginInstaller/DalamudChangelogEntry.cs

@@ -1,7 +1,5 @@
 using System;
 
-using ImGuiScene;
-
 namespace Dalamud.Interface.Internal.Windows.PluginInstaller
 {
     /// <summary>

Dalamud/Interface/Internal/Windows/PluginInstaller/IChangelogEntry.cs

@@ -1,7 +1,5 @@
 using System;
 
-using ImGuiScene;
-
 namespace Dalamud.Interface.Internal.Windows.PluginInstaller
 {
     /// <summary>

Dalamud/Interface/Internal/Windows/PluginInstaller/PluginChangelogEntry.cs

@@ -2,7 +2,6 @@
 
 using Dalamud.Plugin.Internal;
 using Dalamud.Utility;
-using ImGuiScene;
 
 namespace Dalamud.Interface.Internal.Windows.PluginInstaller
 {

Dalamud/Interface/Internal/Windows/PluginInstaller/PluginInstallerWindow.cs

@@ -5,7 +5,6 @@ using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using System.Linq;
-using System.Net.Http;
 using System.Numerics;
 using System.Threading.Tasks;
 

Dalamud/Interface/Internal/Windows/PluginStatWindow.cs

@@ -4,8 +4,6 @@ using System.Linq;
 using System.Reflection;
 
 using Dalamud.Game;
-using Dalamud.Game.Internal;
-using Dalamud.Hooking;
 using Dalamud.Hooking.Internal;
 using Dalamud.Interface.Windowing;
 using Dalamud.Plugin.Internal;

Dalamud/Interface/Internal/Windows/SelfTest/SelfTestWindow.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Diagnostics;
 using System.Linq;
 using System.Numerics;
 

Dalamud/Interface/Internal/Windows/SettingsWindow.cs

@@ -12,7 +12,6 @@ using Dalamud.Game.Gui.Dtr;
 using Dalamud.Game.Text;
 using Dalamud.Interface.Colors;
 using Dalamud.Interface.Components;
-using Dalamud.Interface.GameFonts;
 using Dalamud.Interface.Windowing;
 using Dalamud.Plugin.Internal;
 using Dalamud.Utility;

Dalamud/Interface/Internal/Windows/TitleScreenMenuWindow.cs

@@ -9,7 +9,6 @@ using Dalamud.Game;
 using Dalamud.Game.ClientState;
 using Dalamud.Game.Gui;
 using Dalamud.Interface.Animation.EasingFunctions;
-using Dalamud.Interface.GameFonts;
 using Dalamud.Interface.Windowing;
 using ImGuiNET;
 using ImGuiScene;

Dalamud/Logging/Internal/TaskTracker.cs

@@ -6,7 +6,6 @@ using System.Reflection;
 using System.Threading.Tasks;
 
 using Dalamud.Game;
-using Serilog;
 
 namespace Dalamud.Logging.Internal
 {

Dalamud/Plugin/DalamudPluginInterface.cs

@@ -14,7 +14,6 @@ using Dalamud.Game.Text.Sanitizer;
 using Dalamud.Game.Text.SeStringHandling;
 using Dalamud.Game.Text.SeStringHandling.Payloads;
 using Dalamud.Interface;
-using Dalamud.Interface.Internal;
 using Dalamud.Plugin.Internal;
 using Dalamud.Plugin.Ipc;
 using Dalamud.Plugin.Ipc.Exceptions;

Dalamud/Plugin/Internal/Exceptions/InvalidPluginException.cs

@@ -1,4 +1,3 @@
-using System;
 using System.IO;
 
 namespace Dalamud.Plugin.Internal.Exceptions

Dalamud/Plugin/Internal/Exceptions/InvalidPluginOperationException.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace Dalamud.Plugin.Internal.Exceptions
 {
     /// <summary>

Dalamud/Plugin/Internal/PluginManager.cs

@@ -1126,7 +1126,9 @@ namespace Dalamud.Plugin.Internal
             this.assemblyLocationMonoHook = new MonoMod.RuntimeDetour.Hook(locationTarget, locationPatch);
 
             #pragma warning disable CS0618
+            #pragma warning disable SYSLIB0012
             var codebaseTarget = targetType.GetProperty(nameof(Assembly.CodeBase))?.GetGetMethod();
+            #pragma warning restore SYSLIB0012
             #pragma warning restore CS0618
             var codebasePatch = typeof(PluginManager).GetMethod(nameof(AssemblyCodeBasePatch), BindingFlags.NonPublic | BindingFlags.Static);
             this.assemblyCodeBaseMonoHook = new MonoMod.RuntimeDetour.Hook(codebaseTarget, codebasePatch);

Dalamud/Utility/Util.cs

@@ -8,7 +8,6 @@ using System.Net.Http;
 using System.Numerics;
 using System.Reflection;
 using System.Runtime.CompilerServices;
-using System.Runtime.InteropServices;
 using System.Text;
 
 using Dalamud.Configuration.Internal;