ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2026-02-25 14:11:48 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

chore(network): Remove obsolete IGameNetwork interface

Browse source 
Remove the dead IGameNetwork interface that was already marked with
[Obsolete(..., true)]. Plugins cannot use this interface as the
obsolete attribute causes compile errors.

The internal GameNetwork class remains unchanged and continues to
function for NetworkMonitorWidget and other internal tooling.
This commit is contained in:
RoseOfficial 2026-01-20 14:28:26 -05:00
parent 7f3b233087
commit bcaef7ef47
1 changed files with 0 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

54
Dalamud/Plugin/Services/IGameNetwork.cs
View file

@ -1,54 +0,0 @@
using Dalamud.Game.Network;
namespace Dalamud.Plugin.Services;
/// <summary>
/// This class handles interacting with game network events.
/// </summary>
/// <remarks>
/// <para>
/// <b>DEPRECATED:</b> This interface passes raw unmanaged pointers which are unsafe for the following reasons:
/// </para>
/// <list type="bullet">
/// <item><description>No bounds checking on pointer arithmetic - can cause access violations</description></item>
/// <item><description>No lifetime management - pointer may be freed while plugin holds it</description></item>
/// <item><description>No size information - callers must guess packet boundaries</description></item>
/// <item><description>Async usage can cause use-after-free vulnerabilities</description></item>
/// </list>
/// <para>
/// <b>Migration Guide:</b>
/// </para>
/// <list type="bullet">
/// <item><description>For market board data: Use the MarketBoard observable services</description></item>
/// <item><description>For duty finder: Use DutyFinder observable services</description></item>
/// <item><description>For custom packets: Create typed hooks using <c>Hook&lt;T&gt;</c> with proper packet structures</description></item>
/// </list>
/// <para>
/// See the Dalamud developer documentation for detailed migration instructions.
/// </para>
/// </remarks>
[Obsolete("Will be removed in a future release. Use packet handler hooks instead. See XML documentation for migration guide.", true)]
public interface IGameNetwork : IDalamudService
{
/// <summary>
/// The delegate type of a network message event.
/// </summary>
/// <param name="dataPtr">
/// The pointer to the raw data. WARNING: This pointer has no lifetime guarantees
/// and must not be stored or used asynchronously.
/// </param>
/// <param name="opCode">The operation ID code.</param>
/// <param name="sourceActorId">The source actor ID.</param>
/// <param name="targetActorId">The target actor ID.</param>
/// <param name="direction">The direction of the packet.</param>
public delegate void OnNetworkMessageDelegate(nint dataPtr, ushort opCode, uint sourceActorId, uint targetActorId, NetworkMessageDirection direction);
/// <summary>
/// Event that is called when a network message is sent/received.
/// </summary>
/// <remarks>
/// WARNING: The dataPtr passed to handlers is only valid during the synchronous
/// execution of the handler. Do not store the pointer or use it in async contexts.
/// </remarks>
public event OnNetworkMessageDelegate NetworkMessage;
}