ToxicMushroom/Dalamud
1
0
Fork 0
mirror of https://github.com/goatcorp/Dalamud.git synced 2025-12-12 18:27:23 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

chore: remove IDalamudPlugin.Name

Browse source
This commit is contained in:
goat 2023-09-23 11:17:53 +02:00
parent 60a2051026
commit c55b93d3c2
No known key found for this signature in database
GPG key ID: 49E2AA8C6A76498B
3 changed files with 2 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Dalamud.CorePlugin/PluginImpl.cs
View file

@ -1,5 +1,6 @@
using System; using System;
using System.IO; using System.IO;
using Dalamud.Configuration.Internal; using Dalamud.Configuration.Internal;
using Dalamud.Game.Command; using Dalamud.Game.Command;
using Dalamud.Interface.Windowing; using Dalamud.Interface.Windowing;
@ -37,9 +38,6 @@ namespace Dalamud.CorePlugin
{ {
} }
/// <inheritdoc/>
public string Name => "Dalamud.CorePlugin";
/// <inheritdoc/> /// <inheritdoc/>
public void Dispose() public void Dispose()
{ {
@ -71,7 +69,7 @@ namespace Dalamud.CorePlugin
this.Interface.UiBuilder.OpenConfigUi += this.OnOpenConfigUi; this.Interface.UiBuilder.OpenConfigUi += this.OnOpenConfigUi;
this.Interface.UiBuilder.OpenMainUi += this.OnOpenMainUi; this.Interface.UiBuilder.OpenMainUi += this.OnOpenMainUi;
Service<CommandManager>.Get().AddHandler("/coreplug", new(this.OnCommand) { HelpMessage = $"Access the {this.Name} plugin." }); Service<CommandManager>.Get().AddHandler("/coreplug", new(this.OnCommand) { HelpMessage = "Access the plugin." });
log.Information("CorePlugin ctor!"); log.Information("CorePlugin ctor!");
} }
@ -81,9 +79,6 @@ namespace Dalamud.CorePlugin
} }
} }
/// <inheritdoc/>
public string Name => "Dalamud.CorePlugin";
/// <summary> /// <summary>
/// Gets the plugin interface. /// Gets the plugin interface.
/// </summary> /// </summary>

4
Dalamud/Plugin/IDalamudPlugin.cs
View file

@ -7,8 +7,4 @@ namespace Dalamud.Plugin;
/// </summary> /// </summary>
public interface IDalamudPlugin : IDisposable public interface IDalamudPlugin : IDisposable
{ {
/// <summary>
/// Gets the name of the plugin.
/// </summary>
string Name { get; }
} }

7
Dalamud/Plugin/Internal/Types/LocalPlugin.cs
View file

@ -505,13 +505,6 @@ internal class LocalPlugin : IDisposable
return; return;
} }
// In-case the manifest name was a placeholder. Can occur when no manifest was included.
if (this.manifest.Name.IsNullOrEmpty() && !this.IsDev)
{
this.manifest.Name = this.instance.Name;
this.manifest.Save(this.manifestFile, "manifest name null or empty");
}
this.State = PluginState.Loaded; this.State = PluginState.Loaded;
Log.Information($"Finished loading {this.DllFile.Name}"); Log.Information($"Finished loading {this.DllFile.Name}");
} }