Commit graph

3 commits

Author SHA1 Message Date
Kara
d393fa64b6
Add tests for GameVersionConverter and fix edge case (#1726)
- Adds tests for GameVersionConverter
- Refactors GameVersionConverter to reduce nesting
- Fixes an edge case in GameVersion deserialization in which the JsonConstructor will be invoked even if no properties match
- Adds a test for the GameVersion deserialization edge case
2024-03-18 20:12:34 -07:00
karashiiro
66a04cb45d Fix edge case in GameVersion and refactor
- Test coverage has been added for the entire class, and verbose/redundant code has been refactored
- Fixes JSON serialization: JsonConstructor requires that the ctor parameters match fields/properties of the target class.
Previously, this meant that the JSON constructor would always throw an ArgumentNullException, as `Input` was not a class property.
2024-03-13 21:40:25 -07:00
goat
f44c6794e7
chore: tidy-up, move files shared between dalamud and injector into separate assembly 2023-09-30 16:11:52 +02:00
Renamed from Dalamud/Game/GameVersion.cs (Browse further)