Commit graph

52 commits

Author SHA1 Message Date
Haselnussbomber
c93f04f0e4
Code cleanup (#2439)
* Use new Lock objects

* Fix CA1513: Use ObjectDisposedException.ThrowIf

* Fix CA1860: Avoid using 'Enumerable.Any()' extension method

* Fix IDE0028: Use collection initializers or expressions

* Fix CA2263: Prefer generic overload when type is known

* Fix CA1862: Use the 'StringComparison' method overloads to perform case-insensitive string comparisons

* Fix IDE0270: Null check can be simplified

* Fix IDE0280: Use 'nameof'

* Fix IDE0009: Add '.this'

* Fix IDE0007: Use 'var' instead of explicit type

* Fix IDE0062: Make local function static

* Fix CA1859: Use concrete types when possible for improved performance

* Fix IDE0066: Use switch expression

Only applied to where it doesn't look horrendous.

* Use is over switch

* Fix CA1847: Use String.Contains(char) instead of String.Contains(string) with single characters

* Fix SYSLIB1045: Use 'GeneratedRegexAttribute' to generate the regular expression implementation at compile-time.

* Fix CA1866: Use 'string.EndsWith(char)' instead of 'string.EndsWith(string)' when you have a string with a single char

* Fix IDE0057: Substring can be simplified

* Fix IDE0059: Remove unnecessary value assignment

* Fix CA1510: Use ArgumentNullException throw helper

* Fix IDE0300: Use collection expression for array

* Fix IDE0250: Struct can be made 'readonly'

* Fix IDE0018: Inline variable declaration

* Fix CA1850: Prefer static HashData method over ComputeHash

* Fi CA1872: Prefer 'Convert.ToHexString' and 'Convert.ToHexStringLower' over call chains based on 'BitConverter.ToString'

* Update ModuleLog instantiations

* Organize usings
2026-01-06 08:36:55 -08:00
goaaats
731d7e0f6e Un-whether-or-not the codebase 2025-04-25 22:49:05 +02:00
AllunEve
0a06a9cbbd
Astral fire and Umbral ice are Gone. (#2214)
Co-authored-by: Alluneve <jeroen@buelens.com>
2025-03-26 19:48:32 -07:00
Kaz Wolfe
84f5dad0a3
fix: JobGauge enum casing 2025-03-24 11:31:19 -07:00
goaaats
c0c61c66be Fix warnings 2025-03-24 19:21:04 +01:00
goaaats
fc562778da Rename SMN enums to follow code standards 2025-03-24 19:19:44 +01:00
Ethan Henderson
23c87015b6
add(DRKGauge): Add DeliriumComboStep, and its enum DeliriumStep (#2198) 2025-03-23 15:14:16 -07:00
Ethan Henderson
82dd4629cb
SMNGauge: Fix typo, update CS (#2197)
* chore(SMNGauge): update gauge to latest CS struct
* chore(SMNGauge): Fix `AttunementTimerRemaining` typo
* refactor(SMNGauge): Cast `AttunementType` to a new enum instead of leaving it raw
* fix(SMNGauge): Use `AttunementType` for `Is<X>Attuned`
2025-03-23 15:13:27 -07:00
Infi
c2588cec6b
Switch from CurrentGauge pointer to using the gauge fields address directly (#2094) 2024-11-16 14:51:38 -08:00
goat
bbaf600856
use correct gauge pointer 2024-11-15 19:31:41 +01:00
Haselnussbomber
c0f05614c6
[api11] Some code cleanup and signature replacements (#2066)
* Remove unused code from ChatHandlers

* Replace sigs in DalamudAtkTweaks

* Resolve LocalContentId by using PlayerState.ContentId

* Resolve BuddyList address via UIState.Buddy

* Resolve ObjectTable address via GameObjectManager

* Resolve FateTable address via FateManager

* Resolve GroupManager address via GroupManager

* Resolve JobGauges address via JobGaugeManager.CurrentGauge

* Simplify ItemHover/Out event

* Resolve ToggleUiHide address via RaptureAtkModule.SetUiVisibility

* Resolve PopulateItemLinkObject via InventoryItem.Copy

* Add byte[].AsPointer extension

* Resolve addresses used by ToastGui via UIModule functions

* Use Length from Span as ObjectTableLength

* Replace OpenMapWithMapLink with CS call

* Resolve FrameworkAddressResolver with CS vtable

* Drop unnecessary ToArray in HandlePrintMessage

* Clean up event calls in HandlePrintMessageDetour

* Simplify LocalContentId further

This pointer can't be null, because it's part of the .data section.

* Compare SeStrings in FlyTextGui with SequenceEqual

* Use CS types in FlyTextGuis internal code

* Simplify reading SeStrings internally

* Remove AsPointer again

* Resolve Number/StringArray by type in NamePlateGui

* Fix crashes in HandlePrintMessageDetour

* Resolve InteractableLinkClicked with LogViewer.HandleLinkClick
2024-11-12 08:20:29 -08:00
Asriel Camora
0b9af0e3f4
Update to Lumina 5 (new Excel parsing) (#2022)
* Refactor and upgrade to new excel design

* Obsolete ExcelResolver<T> and use only RowRef<T>

* Better benchmarking for Lumina

* Add custom game-supported RSV provider

* Refactor and move Lazy<T> and nullable/cached row objects to RowRefs

* Convert IRSVProvider to delegate, resolve strings by default

* Split IExcelRow into IExcelSubrow

* Extra lumina documentation

* Minor RSV CS fixes

* Fix UIGlowPayload warning

* Fix rebase

* Update to Lumina 5
2024-10-20 19:59:03 -07:00
attick
4383a5747d
Add SerpentCombo to VPRGauge (#1960)
Co-authored-by: KazWolfe <KazWolfe@users.noreply.github.com>
2024-07-23 21:17:02 -07:00
goat
4d0ab8e254 fix warnings 2024-07-23 19:46:02 +02:00
Tykku
2335c498c5
fix: nin gauge missing kazematoi (#1904)
Added Kazematoi to nin gauge from structs

Co-authored-by: KazWolfe <KazWolfe@users.noreply.github.com>
2024-07-21 16:00:48 -07:00
srkizer
1109e64552
Describe address for debugging, change PresentDetour viewport handling (#1943)
* Describe memory address when printed in log/debug utilities

* PresentDetour: Compare against game's internal copy of IDXGISwapChain

* Handle ReShade on_present function signature properly
2024-07-18 21:28:25 +02:00
pohky
ca3c0c4014
BLM and MNK Gauge Update with CS bump (#1914) 2024-07-10 07:41:50 +00:00
goat
d41682b66e fix warnings 2024-07-07 12:42:46 +02:00
KazWolfe
3727940b5c
Bump ClientStructs for 7.0hf1 (#1901)
* Update ASTGauge

* deps: bump CS

* fix: remove Huton from NIN gauge

---------

Co-authored-by: lazyrain <lazyrain@pm.me>
2024-07-06 20:02:08 +02:00
NostraThomas99
9d9326fd6d
Add support for PCT and VPR to Dalamud.Game.ClientState.JobGauge (#1890)
Added PCTGauge and VPRGauge to the job gauge definitions. Also updated JobGauge widget to support VPR and PCT.
2024-07-05 10:28:24 +02:00
KazWolfe
0c8c4bfdbf
chore: Remove the [InterfaceVersion] attribute (#1844) 2024-06-16 13:01:17 +02:00
goat
448b0d16ea
Add "loading dialog" for service init, unify blocking logic (#1779)
* wip

* hacky fix for overlapping event text in profiler

* move IsResumeGameAfterPluginLoad logic to PluginManager

* fix some warnings

* handle exceptions properly

* remove ability to cancel, rename button to "hide" instead

* undo Dalamud.Service refactor for now

* warnings

* add explainer, show which plugins are still loading

* add some text if loading takes more than 3 minutes

* undo wrong CS merge
2024-04-21 17:28:37 +02:00
Soreepeong
7f5ef03917 Use EarlyLoadedService for anything that is not mandatory for kicking off plugin loader 2024-04-07 21:53:23 +09:00
goat
5809cf5d7c
chore: make all services with interfaces internal 2023-09-17 21:09:00 +02:00
MidoriKami
1d5c3cee11
Add IJobGauges (#1265) 2023-06-24 17:10:53 -07:00
goat
987ff8dc8f
chore: convert Dalamud to file-scoped namespaces 2022-10-29 15:23:22 +02:00
kizer
3369f569fb
Add call-on-services-ready attribute for service methods, and fix scene nullability (#900) 2022-06-26 18:49:34 +02:00
kizer
8e7f370ddd
Load services asynchronously whenever possible (#893) 2022-06-24 22:12:51 +02:00
goat
96ed22534c
chore: fix some warnings, cleanup 2022-04-25 20:04:17 +02:00
Raymond
7efadfbd60 Fix BeastGauge 2021-12-23 16:46:37 -05:00
Raymond
d10aabfa98 docstring fix 2021-12-23 16:46:27 -05:00
Raymond
d7e5251dfd Update DRG gauge 2021-12-10 13:41:18 -05:00
Raymond
00d673a16b Formatting 2021-12-10 13:41:01 -05:00
Raymond
08a0803fde MNKGauge fix + client structs 2021-12-09 13:08:03 -05:00
goaaats
4fe92a59a0
merge #709 2021-12-09 18:49:40 +01:00
goaaats
56d72b44b3
fix(gauges): MNK chakra + nadi, BLM Enochian flags 2021-12-09 18:41:40 +01:00
Raymond
20aae02162 fix: ASTGauge.Seals threw cast error
oops
2021-12-08 10:40:32 -05:00
goaaats
f1ce9b49b3
Merge pull request #704 from daemitus/kaeshi 2021-12-08 03:43:01 +01:00
goat
fb0d0de3ad
fix(SMNGauge): actually return attunement timer instead of summon timer (closes #705) 2021-12-07 21:08:22 +01:00
Raymond
a5a7f5a8dd feat: Add SAMGauge.Kaeshi and enum 2021-12-07 14:21:10 -05:00
Raymond
6eed8935f8 Update bard gauge for Coda, underlying changes 2021-12-07 11:25:13 -05:00
goat
0187e37172
fix: BRD SongTimer short -> ushort 2021-12-07 16:27:40 +01:00
Raymond
8758c4c04d Gauge update (again) 2021-12-05 12:13:02 -05:00
Raymond
f9e71c0023 SGEGauge: add a Addersgall/Eukrasia 2021-12-04 22:11:56 -05:00
Raymond
2fecf0d055 RPRGauge: add Soul 2021-12-04 22:11:42 -05:00
Raymond
858bc40907 RDMGauge: add ManaStacks 2021-12-04 22:11:34 -05:00
Raymond
f53c98b087 ASTGauge: split drawn card 2021-12-04 08:49:37 -05:00
goat
1561fbac00
Revert "refactor(Dalamud): switch to file-scoped namespaces"
This reverts commit b5f34c3199.
2021-11-18 15:23:40 +01:00
goat
b5f34c3199
refactor(Dalamud): switch to file-scoped namespaces 2021-11-17 19:42:32 +01:00
Raymond
53cb193013 DNCGauge break: ulong->uint, feat: expose all steps 2021-08-27 22:02:42 -04:00